On Tue, Dec 04, 2012 at 07:33:54PM +0800, Xiaotian Feng wrote: > megaraid use INIT_WORK to declare a hotplug_work, but cast the hotplug_work > from work_struct to delayed_work and schedule_delayed_work on it. This is > very dangerous, as other part of delayed_work might be kernel memories > allocated > by others. > > With commit 8852aac, schedule_delayed_work() will check dwork->timer before > queue_work, this will cause megaraid code to hit the BUG_ON in workqueue code. > Change megaraid code to use delayed work. > > Signed-off-by: Xiaotian Feng <dannyf...@tencent.com> > Cc: Tejun Heo <t...@kernel.org> > Cc: Neela Syam Kolli <megaraidli...@lsi.com> > Cc: "James E.J. Bottomley" <jbottom...@parallels.com> > Cc: linux-s...@vger.kernel.org
Urgh... what the.... Didn't see that one coming. I'm gonna push this to Linus through the workqueue tree. Thanks for the fix. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
