On Tue, Dec 04, 2012 at 11:39:56AM +0100, Geert Uytterhoeven wrote: > On cris-linux-gcc, __SIZE_TYPE__ expands to "unsigned int", as > gcc-4.6.3-nolibc/cris-linux/lib/gcc/cris-linux/4.6.3/plugin/include/config/cris/linux.h > has > > #define SIZE_TYPE "unsigned int" > > Hence __kernel_size_t is also "unsigned int". But __kernel_ssize_t is > "long", which has a different base type, causing compiler warnings like: > > fs/quota/quota_tree.c:372:4: warning: format '%zd' expects argument of > type 'signed size_t', but argument 4 has type 'ssize_t' [-Wformat] > > To fix this, __kernel_ssize_t should be changed to "int". Hence cris can > just use the generic 32-bit versions from include/asm-generic/posix_types.h > for all size-related types.
Yup, I agree, thanks! > Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> > Cc: Mikael Starvik <star...@axis.com> Acked-by: Jesper Nilsson <jesper.nils...@axis.com> > Cc: Hans-Peter Nilsson <hans-peter.nils...@axis.com> > Cc: linux-cris-ker...@axis.com > --- > arch/cris/include/asm/posix_types.h | 5 ----- > 1 files changed, 0 insertions(+), 5 deletions(-) > > diff --git a/arch/cris/include/asm/posix_types.h > b/arch/cris/include/asm/posix_types.h > index ce4e517..0f22e6a 100644 > --- a/arch/cris/include/asm/posix_types.h > +++ b/arch/cris/include/asm/posix_types.h > @@ -22,11 +22,6 @@ typedef unsigned short __kernel_uid_t; > typedef unsigned short __kernel_gid_t; > #define __kernel_uid_t __kernel_uid_t > > -typedef __SIZE_TYPE__ __kernel_size_t; > -typedef long __kernel_ssize_t; > -typedef int __kernel_ptrdiff_t; > -#define __kernel_size_t __kernel_size_t > - > typedef unsigned short __kernel_old_dev_t; > #define __kernel_old_dev_t __kernel_old_dev_t > > -- > 1.7.0.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nils...@axis.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/