On Fri, 2012-12-07 at 06:28 -0700, Tim Gardner wrote: > The WARN_ON_ONCE() check for scan_request will not correctly detect > a NULL pointer for scan_type == IWL_SCAN_NORMAL. Make it explicit > that the check only applies to normal scans. > > Convert WARN_ON_ONCE to WARN_ON since priv->scan_request really _can't_ > be NULL for normal scans. If it is then we should emit frequent warnings. > > This smatch warning led to scrutiny of iwlagn_request_scan(): > > drivers/net/wireless/iwlwifi/dvm/scan.c:894 iwlagn_request_scan() error: we > previously assumed 'priv->scan_request' could be null (see line 792) > > Cc: Johannes Berg <[email protected]> > Cc: Wey-Yi Guy <[email protected]> > Cc: Intel Linux Wireless <[email protected]> > Cc: "John W. Linville" <[email protected]> > Cc: Emmanuel Grumbach <[email protected]> > Cc: Don Fry <[email protected]> > Cc: [email protected] > Cc: [email protected] > Signed-off-by: Tim Gardner <[email protected]> > --- > > This patch does apply to 3.6.y, but it doesn't fix an existing > bug so I don't think it qualifies. This patch simply makes > the driver more robust for future development. > > V2 - corrected indentation more like the rest of the source > in this file.
Thanks, I've picked it up now, adding one space in the condition still :) It's in my internal tree for now, so it'll be a few days until it trickles out to iwlwifi-next. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
