On Friday 07 December 2012, Thomas Petazzoni wrote:
> The pcim_*() functions are used by the libata-sff subsystem, and this
> subsystem is used for many SATA drivers on ARM platforms that do not
> necessarily have I/O ports.
I think this one is wrong as the CONFIG_HAS_IOPORT does not refer to the
presence of PIO ports but to whether or not they provide an ioport_map
function. If there is no ioport_map(), devm_pci_iomap will fail to link
as far as I can tell.
Arnd
> Signed-off-by: Thomas Petazzoni <thomas.petazz...@free-electrons.com>
> Cc: Paul Gortmaker <paul.gortma...@windriver.com>
> Cc: Jesse Barnes <jbar...@virtuousgeek.org>
> Cc: Yinghai Lu <ying...@kernel.org>
> Cc: linux-kernel@vger.kernel.org
> ---
> lib/devres.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/devres.c b/lib/devres.c
> index 80b9c76..5639c3e 100644
> --- a/lib/devres.c
> +++ b/lib/devres.c
> @@ -195,6 +195,7 @@ void devm_ioport_unmap(struct device *dev, void __iomem
> *addr)
> devm_ioport_map_match, (void *)addr));
> }
> EXPORT_SYMBOL(devm_ioport_unmap);
> +#endif /* CONFIG_HAS_IOPORT */
>
> #ifdef CONFIG_PCI
> /*
> @@ -400,4 +401,3 @@ void pcim_iounmap_regions(struct pci_dev *pdev, int mask)
> }
> EXPORT_SYMBOL(pcim_iounmap_regions);
> #endif /* CONFIG_PCI */
> -#endif /* CONFIG_HAS_IOPORT */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
