On 12/12, Oleg Nesterov wrote: > > On 12/11, Srivatsa S. Bhat wrote: > > > > IOW, the hotplug readers just increment/decrement their per-cpu refcounts > > when no writer is active. > > plus cli/sti ;) and increment/decrement are atomic. ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
OOPS, sorry I was going to say "adds mb()". And when I look at get_online_cpus_atomic() again it uses rmb(). This doesn't look correct, we need the full barrier between this_cpu_inc() and writer_active(). At the same time reader_nested_percpu() can be checked before mb(). Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/