On Tue, Dec 11, 2012 at 10:11 PM, Stephen Warren <swar...@wwwdotorg.org> wrote:
> Since I assume those function are only supposed to be used by pinctrl > drivers themselves, should the prototypes go into drivers/pinctrl/core.h > or similar, rather than something in include/linux/pinctrl? Good point, Julien can you fix this? Hm, maybe pinctrl_force_sleep()/default() isn't such a good name, maybe it should be pinctrl_hogs_sleep()/pinctrl_hogs_default() intead? > Oh, and don't you need EXPORT_SYMBOL in case the pinctrl driver is a module? True. > Aside from that, > > Reviewed-by: Stephen Warren <swar...@nvidia.com> Thanks. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/