On Wed, 2012-12-12 at 16:43 -0500, Johannes Weiner wrote:
> dc0422c "mm: vmscan: only evict file pages when we have plenty" makes

Can't find dc0422c.

> a point of not going for anonymous memory while there is still enough
> inactive cache around.
> 
> The check was added only for global reclaim, but it is just as useful
> for memory cgroup reclaim.
> 
> Signed-off-by: Johannes Weiner <han...@cmpxchg.org>
> ---
>  mm/vmscan.c | 19 ++++++++++---------
>  1 file changed, 10 insertions(+), 9 deletions(-)
> 
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 157bb11..3874dcb 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -1671,6 +1671,16 @@ static void get_scan_count(struct lruvec *lruvec, 
> struct scan_control *sc,
>               denominator = 1;
>               goto out;
>       }
> +     /*
> +      * There is enough inactive page cache, do not reclaim
> +      * anything from the anonymous working set right now.
> +      */
> +     if (!inactive_file_is_low(lruvec)) {
> +             fraction[0] = 0;
> +             fraction[1] = 1;
> +             denominator = 1;
> +             goto out;
> +     }
>  
>       anon  = get_lru_size(lruvec, LRU_ACTIVE_ANON) +
>               get_lru_size(lruvec, LRU_INACTIVE_ANON);
> @@ -1688,15 +1698,6 @@ static void get_scan_count(struct lruvec *lruvec, 
> struct scan_control *sc,
>                       fraction[1] = 0;
>                       denominator = 1;
>                       goto out;
> -             } else if (!inactive_file_is_low_global(zone)) {
> -                     /*
> -                      * There is enough inactive page cache, do not
> -                      * reclaim anything from the working set right now.
> -                      */
> -                     fraction[0] = 0;
> -                     fraction[1] = 1;
> -                     denominator = 1;
> -                     goto out;
>               }
>       }
>  


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to