On Mon, Dec 17, 2012 at 3:26 PM, Yinghai Lu <ying...@kernel.org> wrote: > On Mon, Dec 17, 2012 at 3:11 PM, H. Peter Anvin <h...@zytor.com> wrote: >> On 12/17/2012 02:47 PM, Yinghai Lu wrote: >>> >>> >>> Peter, can you check that branch again? >>> >>> I moved the early_trap_init after init_mem_mapping. >>> so for 64bit native, init_mem_mapping will setup page table for ram from >>> blank. >>> >> >> Looks better, at first glance at least. There are a couple of unnecessary >> changes (the counter in head_64.S cannot exceed 32 bits once computed, so >> the change from %rcx to %ecx change is pointless.) > > ok, return to use %ecx > >> >> There is another bug in my patch: it either needs to mask off the NX bit if >> we are running on non-NX-enabled hardware, or it needs to not set the NX bit >> (which is mostly okay that early on, I suspect.) > > i test that in kvm guest, and westmere, current version seem ok. > > will repost the patchset to list to get more review. >
not sure if i could move that early_trap_init down. jason, We need to move down early_trap_init after init_memory_mapping to use early #PF handler to set page table. So can we do that? for kgdb it is that ok to move it down? or can we just move set_intr_gate(X86_TRAP_PF, &page_fault) back to trap_init? Thanks Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
