On Mon, 10 Dec 2012 10:55:04 +0100, Linus Walleij <linus.wall...@linaro.org> wrote: > On Sat, Dec 8, 2012 at 3:36 AM, Vivien Didelot > <vivien.dide...@savoirfairelinux.com> wrote: > > > Technologic Systems TS-5500 provides digital I/O lines exposed through > > pin blocks. On this platform, there are three of them, named DIO1, DIO2 > > and LCD port, that may be used as a DIO block. > > > > The TS-5500 pin blocks are described in the product's wiki: > > http://wiki.embeddedarm.com/wiki/TS-5500#Digital_I.2FO > > > > This driver is not limited to the TS-5500 blocks. It can be extended to > > support similar boards pin blocks, such as on the TS-5600. > > > > This patch is the V2 of the previous https://lkml.org/lkml/2012/9/25/671 > > with corrections suggested by Linus Walleij. > > > > Signed-off-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com> > > Signed-off-by: Jerome Oufella <jerome.oufe...@savoirfairelinux.com> > > Thanks Vivien, it's looking *very* nice and clean now, so patch applied! > > It's perfectly OK this late before the merge window since it's a new driver. > > Yours, > Linus Walleij
Wait a minute.... this driver looks very much like gpio-generic. It really should be using that interface, not recreating all the gpio infrastructure that has been done so many times before. Please take a look at either send me a follow-on patch to convert it to use gpio-generic, or tell my why gpio-generic isn't appropriate here. It's already in, so I'm not got to take it back out (that wouldn't be very fair), but I may decide to move it to staging. g. -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
