On Wed, Dec 19, 2012 at 12:30:21PM -0800, Stephen Boyd wrote:
> On 12/19/12 11:22, Soren Brinkmann wrote:
[..]
> >
> > A probably unique thing I do is, I set the status of uart0 to disabled.
> > This way
> > I can reuse my rootfs which does not run getty on ttyPS1. And this worked
> > fine
> > before.
> >
>
> Thanks for testing. It seems that clocks are failing to register. Please
> try this patch.
>
> --->8-----
>
> diff --git a/drivers/tty/serial/xilinx_uartps.c
> b/drivers/tty/serial/xilinx_uartps.c
> index 2be22a2..2734715 100644
> --- a/drivers/tty/serial/xilinx_uartps.c
> +++ b/drivers/tty/serial/xilinx_uartps.c
> @@ -948,9 +948,9 @@ static int xuartps_probe(struct platform_device *pdev)
> struct clk *clk;
>
> clk = of_clk_get(pdev->dev.of_node, 0);
> - if (!clk) {
> - dev_err(&pdev->dev, "no clock specified\n");
> - return -ENODEV;
> + if (IS_ERR(clk)) {
> + dev_err(&pdev->dev, "failed to get clock\n");
> + return PTR_ERR(clk);
> }
>
> rc = clk_prepare_enable(clk);
Yes, indeed.
As a side note, this is introduced in my patch "serial: xilinx_uartps:
get clock rate info from dts", which is in xilinx/arm-next (and thus in
linux-next), but as far as I can tell, didn't ever make it into the
arm-soc tree.
Michal, did you have plans for pushing this through arm-soc?
Thanks,
Josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
