On Thu, Dec 20, 2012 at 08:12:08PM +0100, Linus Walleij wrote: > On Wed, Dec 19, 2012 at 6:19 PM, Lee Jones <lee.jo...@linaro.org> wrote: > > > Some platforms provide clocks which require enabling before the > > SMSC911x chip will power on. This patch uses the new common clk > > framework to do just that. If no clock is provided, it will just > > be ignored and the driver will continue to assume that no clock > > is required for the chip to run successfully. > > > > Cc: Steve Glendinning <steve.glendinn...@shawell.net> > > Cc: net...@vger.kernel.org > > Signed-off-by: Lee Jones <lee.jo...@linaro.org> > > Seems to me like it'll do the trick. > Acked-by: Linus Walleij <linus.wall...@linaro.org>
This looks fairly dangerous. What about those platforms which use this driver, but don't provide a clock for it? It looks like this will result in those platforms losing their ethernet support. There's at least a bunch of the ARM evaluation boards which make use of this driver... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
