On Thu, Nov 29, 2012 at 5:47 AM, Yinghai Lu <[email protected]> wrote: > After > > | commit 8548c84da2f47e71bbbe300f55edb768492575f7 > | Author: Takashi Iwai <[email protected]> > | Date: Sun Oct 23 23:19:12 2011 +0200 > | > | x86: Fix S4 regression > | > | Commit 4b239f458 ("x86-64, mm: Put early page table high") causes a S4 > | regression since 2.6.39, namely the machine reboots occasionally at S4 > | resume. It doesn't happen always, overall rate is about 1/20. But, > | like other bugs, once when this happens, it continues to happen. > | > | This patch fixes the problem by essentially reverting the memory > | assignment in the older way. > > Have some page table around 512M again, that will prevent kdump to find 512M > under 768M. > > We need revert that reverting, so we could put page table high again for > 64bit. > > Takashi agreed that S4 regression could be something else. > > https://lkml.org/lkml/2012/6/15/182 > > Signed-off-by: Yinghai Lu <[email protected]> > Reviewed-by: Konrad Rzeszutek Wilk <[email protected]>
Hi, Yinghai and HPA What's the staus of this patch, will it go for 3.8? Is there anything blocking this patch? > --- > arch/x86/mm/init.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c > index 9e17f9e..dbef4ff 100644 > --- a/arch/x86/mm/init.c > +++ b/arch/x86/mm/init.c > @@ -234,8 +234,8 @@ static void __init find_early_table_space(struct > map_range *mr, int nr_range) > #ifdef CONFIG_X86_32 > /* for fixmap */ > tables += roundup(__end_of_fixed_addresses * sizeof(pte_t), > PAGE_SIZE); > -#endif > good_end = max_pfn_mapped << PAGE_SHIFT; > +#endif > > base = memblock_find_in_range(start, good_end, tables, PAGE_SIZE); > if (!base) > -- > 1.7.7 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Regards Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
