Hi Boris, On Fri, 21 Dec 2012 09:32:05 +0100, Borislav Petkov wrote: > On Fri, Dec 21, 2012 at 05:20:18PM +0900, Namhyung Kim wrote: >> Now we have GTK2 implementation, add a new --gtk option to use it. >> >> Cc: Pekka Enberg <[email protected]> >> Signed-off-by: Namhyung Kim <[email protected]> >> --- >> tools/perf/Documentation/perf-annotate.txt | 4 ++++ >> tools/perf/builtin-annotate.c | 5 ++++- >> 2 files changed, 8 insertions(+), 1 deletion(-) >> >> diff --git a/tools/perf/Documentation/perf-annotate.txt >> b/tools/perf/Documentation/perf-annotate.txt >> index c8ffd9fd5c6a..482e1f753127 100644 >> --- a/tools/perf/Documentation/perf-annotate.txt >> +++ b/tools/perf/Documentation/perf-annotate.txt >> @@ -66,6 +66,10 @@ OPTIONS >> used. This interfaces starts by centering on the line with more >> samples, TAB/UNTAB cycles through the lines with more samples. >> >> +--gtk:: Use the GTK interface. Use of --gtk requires (but not uses) a tty, > > What does that even mean? > > * it requires one but doesn't use it by default > > * it requires one but if none is present, falls back to stdio > > * it simply checks for tty presence and uses something completely different > > * something else > > ?
Hmm.. sorry for the unclear message. I just copied description of --tui option and failed to make it clear. :/ Current setup_browser() code checks the stdin to be a tty and if not it assumes piping to other commands so set the use_browser to 0 (stdio) and disables GTK output. Maybe we can change this behavior for --gtk case. >> @@ -307,6 +308,8 @@ int cmd_annotate(int argc, const char **argv, const char >> *prefix __maybe_unused) >> use_browser = 0; >> else if (annotate.use_tui) >> use_browser = 1; >> + else if (annotate.use_gtk) >> + use_browser = 2; > > Btw, acme, those use_browser values could use proper defines like: > > #define PERF_BROWSER_NONE 0 > #define PERF_BROWSER_TUI 1 > #define PERF_BROWSER_GTK 2 > > or even an enum or whatever else comes natural in perf-speak. Looks good, will change in the next spin. Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
