On Sun, 2012-12-23 at 11:01 +0000, Andy Furniss wrote:
> Borislav Petkov wrote:
> 
> > [   28.191072] radeon: `0' invalid for parameter `wb'
> >
> > although the whole driver blubber didn't appear on the console fterwards
> > aso something got turned off allright.
> >
> > Then, I went and tried "radeon.no_wb" where the driver blubber appeared
> > but AGP writeback was still enabled:
> 
> no_wb=1 should work.

Perhaps some of the module_param_named(,,int,) should be bool
Also, are all of the various permissions appropriate?

$ git grep module_param_named drivers/gpu/drm/radeon/
drivers/gpu/drm/radeon/radeon_drv.c:module_param_named(no_wb, radeon_no_wb, 
int, 0444);
drivers/gpu/drm/radeon/radeon_drv.c:module_param_named(modeset, radeon_modeset, 
int, 0400);
drivers/gpu/drm/radeon/radeon_drv.c:module_param_named(dynclks, radeon_dynclks, 
int, 0444);
drivers/gpu/drm/radeon/radeon_drv.c:module_param_named(r4xx_atom, 
radeon_r4xx_atom, int, 0444);
drivers/gpu/drm/radeon/radeon_drv.c:module_param_named(vramlimit, 
radeon_vram_limit, int, 0600);
drivers/gpu/drm/radeon/radeon_drv.c:module_param_named(agpmode, radeon_agpmode, 
int, 0444);
drivers/gpu/drm/radeon/radeon_drv.c:module_param_named(gartsize, 
radeon_gart_size, int, 0600);
drivers/gpu/drm/radeon/radeon_drv.c:module_param_named(benchmark, 
radeon_benchmarking, int, 0444);
drivers/gpu/drm/radeon/radeon_drv.c:module_param_named(test, radeon_testing, 
int, 0444);
drivers/gpu/drm/radeon/radeon_drv.c:module_param_named(connector_table, 
radeon_connector_table, int, 0444);
drivers/gpu/drm/radeon/radeon_drv.c:module_param_named(tv, radeon_tv, int, 
0444);
drivers/gpu/drm/radeon/radeon_drv.c:module_param_named(audio, radeon_audio, 
int, 0444);
drivers/gpu/drm/radeon/radeon_drv.c:module_param_named(disp_priority, 
radeon_disp_priority, int, 0444);
drivers/gpu/drm/radeon/radeon_drv.c:module_param_named(hw_i2c, radeon_hw_i2c, 
int, 0444);
drivers/gpu/drm/radeon/radeon_drv.c:module_param_named(pcie_gen2, 
radeon_pcie_gen2, int, 0444);
drivers/gpu/drm/radeon/radeon_drv.c:module_param_named(msi, radeon_msi, int, 
0444);
drivers/gpu/drm/radeon/radeon_drv.c:module_param_named(lockup_timeout, 
radeon_lockup_timeout, int, 0444);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to