Em Mon, 17 Dec 2012 10:37:14 +0100 Sascha Hauer <s.ha...@pengutronix.de> escreveu:
> On Wed, Nov 14, 2012 at 11:04:42AM -0200, Fabio Estevam wrote: > > commit c045e3f13 (ARM: imx: include iram.h rather than mach/iram.h) changed > > the > > location of iram.h, which causes the following build error when building > > the coda > > driver: > > > > drivers/media/platform/coda.c:27:23: error: mach/iram.h: No such file or > > directory > > drivers/media/platform/coda.c: In function 'coda_probe': > > drivers/media/platform/coda.c:2000: error: implicit declaration of function > > 'iram_alloc' > > drivers/media/platform/coda.c:2001: warning: assignment makes pointer from > > integer without a cast > > drivers/media/platform/coda.c: In function 'coda_remove': > > drivers/media/platform/coda.c:2024: error: implicit declaration of function > > 'iram_free > > > > Since the content of iram.h is not imx specific, move it to > > include/linux/iram.h > > instead. > > Generally we need a fix for this, but: > > > diff --git a/arch/arm/mach-imx/iram.h b/include/linux/iram.h > > similarity index 100% > > rename from arch/arm/mach-imx/iram.h > > rename to include/linux/iram.h > > We shouldn't introduce a file include/linux/iram.h which is purely i.MX > specific. The name is far too generic. I would rather suggest > include/linux/platform_data/imx-iram.h (Although it's not exactly > platform_data, so I'm open for better suggestions). > > As a side note this i.MX specific iram stuff (hopefully) is obsolete > after the next merge window as Philip already has patches for a generic > iram allocator which didn't make it into this merge window. Hi Sasha, This compilation breakage seems to still be happening. Just tested here with arm32 "allmodconfig", on a tree based on Linus one, with -next and -media patches applied on it: drivers/media//platform/coda.c:27:23: fatal error: mach/iram.h: No such file or directory compilation terminated. I don't mind how this would be named, but this should be fixed somehow ;) Regards, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
