On Thu, Jan 03, 2013 at 04:25:09PM +1300, Tony Prisk wrote:
> +static void __init vt8500_timer_init(void)
> +{
> +     struct device_node *np;
> +     int timer_irq;
> +
> +     np = of_find_matching_node(NULL, vt8500_timer_ids);
> +     if (!np) {
> +             pr_err("%s: Timer description missing from Device Tree\n",
> +                                                             __func__);
> +             return;
> +     }
> +     regbase = of_iomap(np, 0);
> +     if (!regbase) {
> +             pr_err("%s: Missing iobase description in Device Tree\n",
> +                                                             __func__);
> +             of_node_put(np);
> +             return;
> +     }
> +     timer_irq = irq_of_parse_and_map(np, 0);
> +     if (!timer_irq) {
> +             pr_err("%s: Missing irq description in Device Tree\n",
> +                                                             __func__);
> +             of_node_put(np);
> +             return;

You are forgetting to unmap the regbase here.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to