On Thu, Jan 03, 2013 at 08:27:31AM -0800, Dave Hansen wrote: > On 01/02/2013 08:28 PM, Minchan Kim wrote: > > VOLATILE imply the the pages in the range isn't working set any more > > so it's pointless that make them to THP/KSM. > > One of the points of this implementation is that it be able to preserve > memory contents when there is no pressure. If those contents happen to > contain a THP/KSM page, and there's no pressure, it seems like the right > thing to do is to leave that memory in place.
Indeed. I should have written more cleary, Current implementation is following as 1. madvised-THP/KSM(1, 10) -> mvolatile(1, 10) -> fail 2. mvolatile(1, 10) -> madvised-THP/KSM(1, 10) -> fail 3. always-THP -> mvolatile -> success -> if memory pressure happens -> split_huge_page -> discard. I think 2,3 makes sense to me but we need to fix 1 in further patches. > > It might be a fair thing to do this in order to keep the implementation > more sane at the moment. But, we should make sure there's some good > text on that in the changelog. Absolutely, Thanks for pointing out, Dave. > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majord...@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"d...@kvack.org";> em...@kvack.org </a> -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
