On Tuesday 08 January 2013, Alexandre Courbot wrote:
> +struct gpio_desc *__must_check devm_gpiod_get(struct device *dev,
> + const char *con_id)
> +{
> + struct gpio_desc **dr;
> + struct gpio_desc *desc;
> +
> + dr = devres_alloc(devm_gpio_release, sizeof(struct gpio_desc *),
> + GFP_KERNEL);
> + if (!dr)
> + return ERR_PTR(-ENOMEM);
> +
> + desc = gpiod_get(dev, con_id);
> + if (IS_ERR_OR_NULL(desc)) {
> + devres_free(dr);
> + return desc;
> + }
Please avoid the use of IS_ERR_OR_NULL(), especially on interfaces you
introduce yourself. AFAICT, gpiod_get cannot return NULL, so you
should not check for that.
> + *dr = desc;
> + devres_add(dev, dr);
> +
> + return 0;
> +}
I'm pretty sure you meant to write 'return desc;' here.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
