On Thu, Jan 03, 2013 at 08:44:15AM +1300, Tony Prisk wrote: > Correct operation for register writes is to perform a busy-wait > after writing the register. Currently the busy wait it performed > before, meaning subsequent register writes to bitfields may occur > before the previous field has been updated. > > Also, all registers are defined as 32-bit read/write. Change > pwm_busy_wait() to use readl rather than readb. > > Improve readability of code with defines for registers and bitfields. > > Signed-off-by: Tony Prisk <li...@prisktech.co.nz> > --- > v2: > Change parenthesis around defines > Replace pr_warn with dev_warn in pwm_busy_wait() > > drivers/pwm/pwm-vt8500.c | 64 > +++++++++++++++++++++++++++++++++++----------- > 1 file changed, 49 insertions(+), 15 deletions(-)
Applied, thanks. Thierry
pgp2ZOwtr6QUv.pgp
Description: PGP signature
