> > > utask->vaddr = bp_vaddr;
> > >
> > > - return arch_uprobe_pre_xol(&uprobe->arch, regs);
> > > + err = arch_uprobe_pre_xol(&uprobe->arch, regs);
> > > + if (unlikely(err)) {
> > > + xol_free_insn_slot(current);
> > > + return err;
> > > + }
> > > +
> > > + return 0;
> > > }
> >
> > Nit: we could reduce a line or two with
> >
> > err = arch_uprobe_pre_xol(&uprobe->arch, regs);
> > if (unlikely(err))
> > xol_free_insn_slot(current);
> >
> > return err;
>
> Yes, but this is also preparation for the next patch which adds more
> code after arch_uprobe_pre_xol() == 0.
>
Agree
--
Thanks and Regards
Srikar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
