On 01/11/2013 10:42 PM, Stefan Hajnoczi wrote: > On Fri, Jan 11, 2013 at 04:50:41PM +0800, Jason Wang wrote: >> @@ -1546,6 +1544,9 @@ static int tun_set_iff(struct net *net, struct file >> *file, struct ifreq *ifr) >> struct net_device *dev; >> int err; >> >> + if (rcu_dereference_protected(tfile->detached, lockdep_rtnl_is_held())) >> + return -EINVAL; >> + > How come none of the other tfile->detached users call rcu_*()?
Right, no need to use rcu, the access were protected by rtnl lock. Will repost. > Stefan > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
