On Wed, 9 Jan 2013, Mark Rutland wrote:
> +#ifdef CONFIG_GENERIC_CLOCKEVENTS_BROADCAST
> +extern int tick_receive_broadcast(void);
> +#else
> +static inline int tick_receive_broadcast(void)
> +{
> + return 0;
> +}
What's the inline function for? If an arch does not have broadcasting
support it should not have a receive broadcast function call either.
> +#endif
> +
> #ifdef CONFIG_GENERIC_CLOCKEVENTS
> extern void clockevents_notify(unsigned long reason, void *arg);
> #else
> diff --git a/kernel/time/tick-broadcast.c b/kernel/time/tick-broadcast.c
> index f113755..5079bb7 100644
> --- a/kernel/time/tick-broadcast.c
> +++ b/kernel/time/tick-broadcast.c
> @@ -125,6 +125,18 @@ int tick_device_uses_broadcast(struct clock_event_device
> *dev, int cpu)
> return ret;
> }
>
> +int tick_receive_broadcast(void)
> +{
> + struct tick_device *td = this_cpu_ptr(&tick_cpu_device);
> + struct clock_event_device *evt = td->evtdev;
> +
> + if (!evt)
> + return -ENODEV;
Is anything going to use the return value?
Thanks,
tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
