On Tue, Jan 15, 2013 at 5:48 AM, Stefano Stabellini <[email protected]> wrote:
> > If you are going to put a comment like that in the code, could you > please at least add some useful details, rather than a generic > "somehow"? It doesn't seem very helpful to me or to any other hackers > looking at the code. > > The issue is even described as a comment in the code at the beginning of > arch/x86/xen/mmu.c:xen_setup_kernel_pagetable: > > /* max_pfn_mapped is the last pfn mapped in the initial memory > * mappings. Considering that on Xen after the kernel mappings we > * have the mappings of some pages that don't exist in pfn space, we > * set max_pfn_mapped to the last real pfn mapped. */ > > Now if max_pfn_mapped is supposed to represent the last pfn mapped in > the initial memory mapping, then I think that the way Xen uses > max_pfn_mapped is actually correct. change the comments to: + /* + * Native path, max_pfn_mapped is not set yet. + * Xen has valid max_pfn_mapped set in + * arch/x86/xen/mmu.c:xen_setup_kernel_pagetable(). + */ Thanks Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
