On Wed, 2013-01-16 at 06:45 +1300, Tony Prisk wrote: > On Tue, 2013-01-15 at 16:55 +0200, Artem Bityutskiy wrote: > > On Mon, 2012-12-31 at 10:00 +1300, Tony Prisk wrote: > > > This patch adds support for the Wondermedia serial flash controller > > > found on WM8505, WM8650 and WM8850 SoCs. > > > > > > Signed-off-by: Tony Prisk <li...@prisktech.co.nz> > > > --- > > > v2: Whitespace tidyup > > > > Hi, would you please take a look at these warings, identified by aiaiai: > > > > Successfully built configuration "x86_64_defconfig,x86_64,", results: > > > > --- before_patching.log > > +++ after_patching.log > > @@ @@ > > +drivers/mtd/devices/wmt_sflash.c: In function ‘sf_read’: > > +drivers/mtd/devices/wmt_sflash.c:425:9: warning: format ‘%d’ expects > > argument of type ‘int’, but argument 4 has type ‘size_t’ [-Wformat] > > +drivers/mtd/devices/wmt_sflash.c: In function ‘sf_sector_write’: > > +drivers/mtd/devices/wmt_sflash.c:442:16: warning: cast from pointer to > > integer of different size [-Wpointer-to-int-cast] > > +drivers/mtd/devices/wmt_sflash.c:442:24: warning: cast removes address > > space of expression [sparse] > > +drivers/mtd/devices/wmt_sflash.c:458:16: warning: cast to pointer from > > integer of different size [-Wint-to-pointer-cast] > > +drivers/mtd/devices/wmt_sflash.c:458:31: warning: incorrect type in > > argument 1 (different address spaces) [sparse] > > +drivers/mtd/devices/wmt_sflash.c:458:31: expected void volatile > > [noderef] <asn:2>*dst [sparse] > > +drivers/mtd/devices/wmt_sflash.c:458:31: got unsigned char [usertype] > > *<noident> [sparse] > > +drivers/mtd/devices/wmt_sflash.c:465:17: warning: cast to pointer from > > integer of different size [-Wint-to-pointer-cast] > > +drivers/mtd/devices/wmt_sflash.c:465:39: warning: incorrect type in > > argument 1 (different address spaces) [sparse] > > +drivers/mtd/devices/wmt_sflash.c:465:39: expected void volatile > > [noderef] <asn:2>*dst [sparse] > > +drivers/mtd/devices/wmt_sflash.c:465:39: got unsigned char [usertype] > > *<noident> [sparse] > > > > Apologies - This driver shouldn't be selectable for x86_64. > It is an ARM driver for an embedded device. Will fix.
Note, there are also warnings when it is compiled for other platforms, not only x86_64. Take a look at them. Also note, than many warnings come from sparse, you probably just did not run it. -- Best Regards, Artem Bityutskiy
signature.asc
Description: This is a digitally signed message part
