On Thu, Jan 17, 2013 at 10:36:19AM +0100, Linus Walleij wrote: > On Mon, Jan 7, 2013 at 11:44 AM, Mika Westerberg > <mika.westerb...@linux.intel.com> wrote: > > > The PXA SPI driver uses PXA platform specific private DMA implementation > > which does not work on non-PXA platforms. In order to use this driver on > > other platforms we need to move the private DMA implementation into a > > separate functions that get stubbed out when !CONFIG_ARCH_PXA. > > > > While we are there we can kill the dummy DMA bits in pxa2xx_spi.h as they > > are not needed anymore for CE4100. > > > > Once this is done we can add the generic DMA engine support to the driver > > that allows usage of any DMA controller that implements DMA engine API. > > > > Signed-off-by: Mika Westerberg <mika.westerb...@linux.intel.com> > > --- > > drivers/spi/spi-pxa2xx.c | 612 > > +++++++++++++++++++++++----------------- > > include/linux/spi/pxa2xx_spi.h | 80 ------ > > Can you even break this out to its own file? > > Like drivers/spi/spi-pxa2xx-pxadma.c/.h > with stubs in the header file or something so we need > no #ifdefs in the main driver file?
Good point. I need to refresh the series anyway because of the x86 common clock changes (which I'm hoping the x86 maintainers accept), so I can do the file split as well. > The kernel looks better after this patch anyway, so > Acked-by: Linus Walleij <linus.wall...@linaro.org> > in any case. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
