Stefan Richter wrote: > On Jan 20 YOSHIFUJI Hideaki wrote: >> It is wrong to set skb->ip_summed to CHECKSUM_UNNECESSARY unless >> the device has already checked it. >> >> Signed-off-by: YOSHIFUJI Hideaki <yoshf...@linux-ipv6.org> >> --- >> drivers/firewire/net.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/firewire/net.c b/drivers/firewire/net.c >> index e7a711f5..df6a1ca 100644 >> --- a/drivers/firewire/net.c >> +++ b/drivers/firewire/net.c >> @@ -520,7 +520,7 @@ static int fwnet_finish_incoming_packet(struct >> net_device *net, >> dev = netdev_priv(net); >> /* Write metadata, and then pass to the receive level */ >> skb->dev = net; >> - skb->ip_summed = CHECKSUM_UNNECESSARY; /* don't check it */ >> + skb->ip_summed = CHECKSUM_NONE; >> >> /* >> * Parse the encapsulation header. This actually does the job of > > Indeed neither the device nor the lower drivers check protocol checksums. > But the CRCs of the encapsulating 1394 packets are checked in hardware. > Shall protocol checksums be verified regardless?
Yes, because packets may come from off-link source. --yoshfuji -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
