On Sat, Jan 19, 2013 at 02:02:15AM -0700, Jon Mason wrote: > Atomic readq and writeq do not exist by default on some 32bit > architectures, thus causing compile errors due to non-existent symbols. > In those cases, use the definitions of those symbols from > include/asm-generic/io-64-nonatomic-hi-lo.h > > Signed-off-by: Jon Mason <jon.ma...@intel.com> > --- > drivers/ntb/ntb_hw.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/ntb/ntb_hw.c b/drivers/ntb/ntb_hw.c > index 4c71b17..0b46fef 100644 > --- a/drivers/ntb/ntb_hw.c > +++ b/drivers/ntb/ntb_hw.c > @@ -45,6 +45,7 @@ > * Contact Information: > * Jon Mason <jon.ma...@intel.com> > */ > +#include <asm-generic/io-64-nonatomic-hi-lo.h>
Really? This seems really odd. Usually we just don't build the code for any platform that doesn't have readq/writeq. Otherwise, shouldn't those arches just include this file themselves to keep everything working? Individual drivers shouldn't have to do this. So, I'm not going to take this one just yet, sorry. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
