Hi Cyrill, Agree, will clean this up.
Thanks -----Original Message----- From: Cyrill Gorcunov [mailto:gorcu...@gmail.com] On Behalf Of Cyrill Gorcunov Sent: Monday, January 21, 2013 3:32 PM To: Kinney, Steven Cc: Thomas Gleixner; Ingo Molnar; H. Peter Anvin; x...@kernel.org; Joerg Roedel; Bjorn Helgaas; Greg Kroah-Hartman; Sebastian Andrzej Siewior; Myron Stowe; Hiroshi DOYU; Stephen Warren; Jiri Kosina; Kukjin Kim; linux-kernel@vger.kernel.org; io...@lists.linux-foundation.org; Peter Zijlstra; Paul Mackerras; Arnaldo Carvalho de Melo; Thomas Renninger; Andi Kleen Subject: Re: [PATCH 2/3] AMD IOMMUv2 PC resource management hooks On Mon, Jan 21, 2013 at 02:20:57PM -0600, Steven L. Kinney wrote: > +u8 amd_iommu_v2_get_max_pc_banks(u16 devid) { > + struct amd_iommu *iommu; > + > + /* locate the iommu governing the devid */ > + iommu = amd_iommu_rlookup_table[devid]; > + > + if (iommu) > + return iommu->max_banks; > + > + return -ENODEV; > +} > +EXPORT_SYMBOL(amd_iommu_v2_get_max_pc_banks); Hi Steven, may not it be better to return int here, instead of u8? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/