On Tue, 2013-01-22 at 12:14 -0800, Tony Lindgren wrote: > * Luciano Coelho <[email protected]> [130121 03:16]: > > This reverts commit eccf2979b2c034b516e01b8a104c3739f7ef07d1. > > > > The reason is that it broke TI WiLink shared transport on Panda. > > Also, callback functions should not be added to board files anymore, > > so revert to implementing the power functions in the driver itself. > > > > Additionally, changed a variable name ('status' to 'err') so that this > > revert compiles properly. > > > > Cc: stable <[email protected]> [3.7] > > Signed-off-by: Luciano Coelho <[email protected]> > > This also makes sense from converting to DT based boot as the GPIO > calls should happen in the driver. Those mdelays probably can be fixed, > but since this is a revert to a known working version:
I thought about checking exactly what we need as delays and whether we really need to do all that toggling. At least in some boards, the toggles are not needed, but I don't know for sure whether it works in all different variations of the chip, so I kept them to be safe. Also, I tried to deviate as little as possible from a plain revert, since I'd like to get this into stable as well. > Acked-by: Tony Lindgren <[email protected]> Thanks! -- Luca. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
