On Tue, Jan 22, 2013 at 02:31:53, Peter Korsgaard wrote: > >>>>> "Philip" == Philip Avinash <avinashphi...@ti.com> writes: > > Philip> From: "Philip, Avinash" <avinashphi...@ti.com> > Philip> Add GPMC data node to AM33XX device tree file. > > Philip> Signed-off-by: Philip Avinash <avinashphi...@ti.com> > Philip> --- > Philip> arch/arm/boot/dts/am33xx.dtsi | 12 ++++++++++++ > Philip> 1 file changed, 12 insertions(+) > > Philip> diff --git a/arch/arm/boot/dts/am33xx.dtsi > b/arch/arm/boot/dts/am33xx.dtsi > Philip> index eaef5e7..f4209d8 100644 > Philip> --- a/arch/arm/boot/dts/am33xx.dtsi > Philip> +++ b/arch/arm/boot/dts/am33xx.dtsi > Philip> @@ -393,5 +393,17 @@ > Philip> ti,hwmods = "elm"; > Philip> status = "disabled"; > Philip> }; > Philip> + > Philip> + gpmc: gpmc@50000000 { > Philip> + compatible = "ti,am3352-gpmc"; > Philip> + ti,hwmods = "gpmc"; > Philip> + reg = <0x50000000 0x2000>; > Philip> + interrupts = <100>; > Philip> + num-cs = <8>; > > Next to Jan's comment about am335x having 7 cs signals, I just realized > the difference in compatible string between the gpmc and elm. The gpmc > refers to a real device (which is afaik how it should be done), but the > elm compatible is simply ti,am33xx-elm. > > Presumably it should have been ti,am3352-elm in the binding instead?
I thought of following the file name convention. I will correct to "ti,am3352-elm" > > Other than that it looks fine. > > Acked-by: Peter Korsgaard <jac...@sunsite.dk> Thanks Avinash > > -- > Bye, Peter Korsgaard > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/