Commit-ID:  585376216a829d1ddfb3e57cb50c72c23adb484f
Gitweb:     http://git.kernel.org/tip/585376216a829d1ddfb3e57cb50c72c23adb484f
Author:     Cong Ding <ding...@gmail.com>
AuthorDate: Mon, 14 Jan 2013 17:13:35 +0000
Committer:  Ingo Molnar <mi...@kernel.org>
CommitDate: Thu, 24 Jan 2013 13:07:23 +0100

x86/boot: Fix minor fd leakage in tools/relocs.c

The opened file should be closed.

Signed-off-by: Cong Ding <ding...@gmail.com>
Cc: Kusanagi Kouichi <sl...@ac.auone-net.jp>
Cc: Jarkko Sakkinen <jarkko.sakki...@intel.com>
Cc: Jiri Kosina <jkos...@suse.cz>
Cc: Matt Fleming <matt.flem...@intel.com>
Link: 
http://lkml.kernel.org/r/1358183628-27784-1-git-send-email-ding...@gmail.com
Signed-off-by: Ingo Molnar <mi...@kernel.org>
---
 arch/x86/tools/relocs.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/x86/tools/relocs.c b/arch/x86/tools/relocs.c
index 5a1847d..79d67bd 100644
--- a/arch/x86/tools/relocs.c
+++ b/arch/x86/tools/relocs.c
@@ -814,12 +814,14 @@ int main(int argc, char **argv)
        read_relocs(fp);
        if (show_absolute_syms) {
                print_absolute_symbols();
-               return 0;
+               goto out;
        }
        if (show_absolute_relocs) {
                print_absolute_relocs();
-               return 0;
+               goto out;
        }
        emit_relocs(as_text, use_real_mode);
+out:
+       fclose(fp);
        return 0;
 }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to