Found with coccicheck.
The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.

Signed-off-by: Peter Huewe <peterhu...@gmx.de>
---
 drivers/staging/media/go7007/go7007-driver.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/media/go7007/go7007-driver.c 
b/drivers/staging/media/go7007/go7007-driver.c
index ece2dd1..0e299f0 100644
--- a/drivers/staging/media/go7007/go7007-driver.c
+++ b/drivers/staging/media/go7007/go7007-driver.c
@@ -108,14 +108,13 @@ static int go7007_load_encoder(struct go7007 *go)
                return -1;
        }
        fw_len = fw_entry->size - 16;
-       bounce = kmalloc(fw_len, GFP_KERNEL);
+       bounce = kmemdup(fw_entry->data + 16, fw_len, GFP_KERNEL);
        if (bounce == NULL) {
                v4l2_err(go, "unable to allocate %d bytes for "
                                "firmware transfer\n", fw_len);
                release_firmware(fw_entry);
                return -1;
        }
-       memcpy(bounce, fw_entry->data + 16, fw_len);
        release_firmware(fw_entry);
        if (go7007_interface_reset(go) < 0 ||
                        go7007_send_firmware(go, bounce, fw_len) < 0 ||
-- 
1.7.8.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to