On Sun, 2013-01-27 at 03:35 -0800, Jeff Kirsher wrote:
> This patch reverts a portion of the commit to allow multi-line code
> comments to use either style.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -1878,13 +1878,6 @@ sub process {
> }
>
> if ($realfile =~ m@^(drivers/net/|net/)@ &&
> - $rawline =~ /^\+[ \t]*\/\*[ \t]*$/ &&
> - $prevrawline =~ /^\+[ \t]*$/) {
> - WARN("NETWORKING_BLOCK_COMMENT_STYLE",
> - "networking block comments don't use an empty /*
> line, use /* Comment...\n" . $hereprev);
> - }
> -
> - if ($realfile =~ m@^(drivers/net/|net/)@ &&
> $rawline !~ m@^\+[ \t]*\*/[ \t]*$@ && #trailing */
> $rawline !~ m@^\+.*/\*.*\*/[ \t]*$@ && #inline /*...*/
> $rawline !~ m@^\+.*\*{2,}/[ \t]*$@ && #trailing **/
Shrug.
Ignore things you don't agree with.
David has written many, many emails
requesting changes for this specific
comment style.
I think you and Intel should use
--ignore=NETWORKING_BLOCK_COMMENT_STYLE
to avoid seeing this if you don't agree
with it.
I also think expectations that everyone
will agree with every checkpatch bleat
are unrealistic.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
