>>> On 25.01.13 at 18:32, Konrad Rzeszutek Wilk <[email protected]> wrote: > The 'handle' is the device that the request is from. For the life-time > of the ring we copy it from a request to a response so that the frontend > is not surprised by it. But we do not need it - when we start processing > I/Os we have our own 'struct phys_req' which has only most essential > information about the request. In fact the 'vbd_translate' ends up > over-writing the preq.dev with a value from the backend. > > This assignment of preq.dev with the 'handle' value is superfluous > so lets not do it. > > Cc: [email protected]
Is this really stable material? It fixes nothing but the (wrong) impression that the driver might be using frontend provided data without checking. Jan > Acked-by: Jan Beulich <[email protected]> > Acked-by: Ian Campbell <[email protected]> > Signed-off-by: Konrad Rzeszutek Wilk <[email protected]> > --- > drivers/block/xen-blkback/blkback.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/block/xen-blkback/blkback.c > b/drivers/block/xen-blkback/blkback.c > index 742871d..2de3da9 100644 > --- a/drivers/block/xen-blkback/blkback.c > +++ b/drivers/block/xen-blkback/blkback.c > @@ -890,7 +890,6 @@ static int dispatch_rw_block_io(struct xen_blkif *blkif, > goto fail_response; > } > > - preq.dev = req->u.rw.handle; > preq.sector_number = req->u.rw.sector_number; > preq.nr_sects = 0; > > -- > 1.8.0.2 > > > _______________________________________________ > Xen-devel mailing list > [email protected] > http://lists.xen.org/xen-devel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
