On Thursday, January 31, 2013 10:13:17 AM Bjorn Helgaas wrote:
> [+cc Rafael]
>
> On Mon, Jan 28, 2013 at 3:00 AM, Paul Bolle <pebo...@tiscali.nl> wrote:
> > In each suspend and resume cycle my laptop prints these messages at
> > KERN_INFO level:
> > pciehp 0000:00:1c.1:pcie04: pciehp_suspend ENTRY
> > pciehp 0000:00:1c.0:pcie04: pciehp_suspend ENTRY
> >
> > and
> > pciehp 0000:00:1c.0:pcie04: pciehp_resume ENTRY
> > pciehp 0000:00:1c.1:pcie04: pciehp_resume ENTRY
> >
> > Messages like these are probably only useful while debugging pciehp, so
> > let's hide them behind the ctrl_dbg() macro.
> >
> > Signed-off-by: Paul Bolle <pebo...@tiscali.nl>
> > ---
> > 0) Compile tested only!
> >
> > 1) Perhaps a better solution is to drop these messages entirely.
> >
> > drivers/pci/hotplug/pciehp_core.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/pci/hotplug/pciehp_core.c
> > b/drivers/pci/hotplug/pciehp_core.c
> > index 939bd1d..ed1702d 100644
> > --- a/drivers/pci/hotplug/pciehp_core.c
> > +++ b/drivers/pci/hotplug/pciehp_core.c
> > @@ -293,7 +293,8 @@ static void pciehp_remove(struct pcie_device *dev)
> > #ifdef CONFIG_PM
> > static int pciehp_suspend (struct pcie_device *dev)
> > {
> > - dev_info(&dev->device, "%s ENTRY\n", __func__);
> > + struct controller *ctrl = get_service_data(dev);
> > + ctrl_dbg(ctrl, "%s ENTRY\n", __func__);
> > return 0;
>
> I'd propose to just drop these messages completely. Rafael, would you
> have any objection to that?
No, I wouldn't.
>
> > }
> >
> > @@ -303,8 +304,8 @@ static int pciehp_resume (struct pcie_device *dev)
> > struct slot *slot;
> > u8 status;
> >
> > - dev_info(&dev->device, "%s ENTRY\n", __func__);
> > ctrl = get_service_data(dev);
> > + ctrl_dbg(ctrl, "%s ENTRY\n", __func__);
> >
> > /* reinitialize the chipset's event detection logic */
> > pcie_enable_notification(ctrl);
> > --
Thanks,
Rafael
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
