Hi, On Mon, Feb 4, 2013 at 1:49 PM, MyungJoo Ham <myungjoo....@samsung.com> wrote: >> Hi, >> >> > Sorry for being late. >> > >> > One concern is that I cannot apply Patch 1/4 directly as the .dts file >> > isn't >> > available to me. >> > Do you intend to apply that patch to another tree and apply the other three >> > to devfreq tree? >> I have been merging the devfreq tree into Kgene's tree for my testing. I am >> not >> sure how this should get in, any suggestions ? > > I'd suggest to send Patch 1/4 to Kgene and get it applied first if that patch > is preliminary to the other patchset. If it is not, we can go seperated and > independently. Thanks for the suggestion. Kgene is a recipient on patches 1 and 2. I am hoping he'll pick it up soon. However, the devfreq patches are not dependent on them and can be applied independently. > >> > >> > Another is the location of exynos_ppmu.h. >> > Who is going to refer exynos_ppmu.h? >> > If Exynos devfreq drivers are the only files to refer, wouldn't it be >> > better >> > located at drivers/devfreq/exynos/ ? >> > >> > Or do you intend to let someone else (drivers located not in >> > drivers/devfreq) access exynos-ppmu? >> > (If so, who's going to be? and that means we are going to have >> > include/linux/devfreq/, I don't think it'd be appropriate to populate >> > include/linux with device driver specific headers) >> In an earlier comment on this patch Olof suggested I place it in >> include/linux/. It is going to be >> used only by Exynos and I will move it into drivers/devfreq/exynos as >> per your suggestion. > > If it is to be used by Exynos non-devfreq drivers (e.g., Exynos ADC driver in > drivers/iio/...), it should be stting on include/linux/devfreq/. If it is to > be used by Exynos devfreq drivers only, it'd be better located at > drivers/devfreq/exynos/. It appears to be still compatible with Olof's > suggestion: > > (quoting Olof) "Local defines that are used in just one C file can either go > in that file, or in a header file that sits next to it instead of in the > shared directory." Understood, updated patch 4/4 in a bit. > >
Abhilash -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
