Hey,
On Mon, Feb 04, 2013 at 01:10:34PM -0500, chas williams - CONTRACTOR wrote:
> you assign id1 to 0, so this never happens i think. i don't think the
> reason to preassign id1/id2 exists anymore once the do loop is removed.
>
> > + id1 = idr_alloc(&card->idr, handle1, 0, 0, GFP_ATOMIC);
> > + if (id1 < 0) {
> > + err = id1;
>
> you dont need to assign err since it isn't returned.
Heh, I put v2 under the wrong thread. I'll do v3 and post it under
v1.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
