On Tue, 5 Feb 2013, Huang Shijie wrote:
Add a new module parameter 'pattern'. If it is set to zero, we will use the 55/AA pattern to torture the nand blocks; if it is set to a non-zero value, we will use the random data pattern.
Not a big issue in any way, but if you're using a numeric parameter value anyway, could not one use a range of the permissable values to set a seed for the random generation, so that the test can be repeated with the same set of random numbers?
Something like 0 => 55/AA -1 => random 1 and up => random, specifying seed for random number generator.
+MODULE_PARM_DESC(pattern, "0 for 55/AA pattern(default), else for + the random pattern");
I'd suggest something like "0 for 55/AA pattern (default), non-zero for random pattern".
(Or "-1 for 55/AA pattern (default), else random; >=1 sets seed" if changed according to the above).
/Ricard -- Ricard Wolf Wanderlöf ricardw(at)axis.com Axis Communications AB, Lund, Sweden www.axis.com Phone +46 46 272 2016 Fax +46 46 13 61 30 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
