DOMAIN_ATTR_PAMU_ENABLE is required to enable a particular DMA window. My point is about the domain geometry, which is incomplete in case of PAMU without the number of subwindows. Geometry parameters are used for initializing the PAMU window settings. Individual subwindows can only be enabled, once the PAMU window has been initialized using the geometry settings.
Regards Varun > -----Original Message----- > From: Joerg Roedel [mailto:j...@8bytes.org] > Sent: Tuesday, February 05, 2013 4:12 PM > To: Sethi Varun-B16395 > Cc: Stuart Yoder; io...@lists.linux-foundation.org; linux- > ker...@vger.kernel.org; Wood Scott-B07421 > Subject: Re: [PATCH 5/5] iommu: Add DOMAIN_ATTR_WINDOWS domain attribute > > Hi, > > On Tue, Feb 05, 2013 at 09:14:40AM +0000, Sethi Varun-B16395 wrote: > > In case of PAMU, geometry would be meaningless without specifying the > > number of subwindows. If the API user specifies a geometry but fails > > to specify the number of required subwindows, we would assume a > > default (max supported) value, which may be incorrect. It's going to > > be really ugly. I think we should add the number of sub windows to the > > domain geometry. This parameter would be used in case of a window > > based iommu. So, a separate set_window API wouldn't be required. > > I think this can all be implemented with the interface proposed here > together with a PAMU-specific DOMAIN_ATTR_PAMU_ENABLE attribute. Stuart > outlined in his RFC mail how this can be done. I don't consider this > ugly, it is rather a clean tradeoff between putting functionality into > the generic part of the IOMMU-API and putting it into the PAMU specific > part. > > Regards, > > Joerg > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
