[PATCH 1/6] kvm tools: Return error status in lkvm list

[Michael Ellerman]

Currently list always returns 0, even if there was an error. Instead
have it accumulate any errors and return that.

Signed-off-by: Michael Ellerman <mich...@ellerman.id.au>
---
 tools/kvm/builtin-list.c |   10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/tools/kvm/builtin-list.c b/tools/kvm/builtin-list.c
index 9299f17..c35be93 100644
--- a/tools/kvm/builtin-list.c
+++ b/tools/kvm/builtin-list.c
@@ -123,7 +123,7 @@ static void parse_setup_options(int argc, const char **argv)
 
 int kvm_cmd_list(int argc, const char **argv, const char *prefix)
 {
-       int r;
+       int status, r;
 
        parse_setup_options(argc, argv);
 
@@ -133,17 +133,23 @@ int kvm_cmd_list(int argc, const char **argv, const char 
*prefix)
        printf("%6s %-20s %s\n", "PID", "NAME", "STATE");
        printf("------------------------------------\n");
 
+       status = 0;
+
        if (run) {
                r = kvm_list_running_instances();
                if (r < 0)
                        perror("Error listing instances");
+
+               status |= r;
        }
 
        if (rootfs) {
                r = kvm_list_rootfs();
                if (r < 0)
                        perror("Error listing rootfs");
+
+               status |= r;
        }
 
-       return 0;
+       return status;
 }
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/