Hello, Hillf. On Thu, Feb 07, 2013 at 08:13:44PM +0800, Hillf Danton wrote: > > If this is meant as a pure cleanup, I'm not sure it's an improvement. > > You own your cpu_stop_done until you call cpu_stop_signal_done() on > > it, so I don't think there's anything wrong with the current code. > > The new code is different, not necessarily better. > > The comment just above cpu_stop_signal_done() > says it is not certain that the input done is valid, so > I did this work. > Plus works enqueued through stop_one_cpu_nowait() > do carry no done.
So, are you saying that we can hit NULL deref in cpu_stopper_thread() and this is a bug fix? If so, can you please redo the description? I really can't tell what the patch is trying to do from the original description. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
