On Thu, Feb 7, 2013 at 4:56 PM, Alexey Brodkin <[email protected]> wrote: > On 02/07/2013 08:44 PM, Grant Likely wrote: >> So, if I'm correct that means that for the data port (specifically >> copying between RAM and the data port) using ioread16/iowrite16 on the >> data port results in the correct behaviour. It also means that LE >> support in the current driver is broken. > > That matches my earlier note when I wrote that for correct work on LE (note > I'm on ARC, not PPC/MB) I needed to use "io{read|write}16" in > "ace_data{in|out}_le16". > > With original "io{read|write}16be" instead data was corrupted.
In which case your bug-fix patch should drop the ace_datain_le16/ace_dataout_le16 variants entirely and use the be16 ones for both (renaming appropriately). g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
