On Thu, 07 Feb 2013 20:01:27 +0900 Jonghwa Lee <[email protected]> wrote:
> This patch adds rtc driver for Maxim 8997 multifunction chip. > Max8997 has rtc module in it. and it can be used for timekeeping > clock and system alarm. It provide various operational mode those are > BCD/binary, 24/12hour, am/pm. Driver sets binary/24/ for default. > Maxim 8997 also supports SMPL(Sudden Momentary Power Loss), WTSR > (Watchdog Timeout and Software Reset). > > Signed-off-by: Jonghwa Lee <[email protected]> > --- > v2 > - Add module parameter to enable/disable WTSR, SMPL fuction. > - Add unregister_rtc_device() for accidental exit in probing. > > ... > > +/* Module parameter for WTSR function control */ > +static int wtsr_en = 1; > +module_param(wtsr_en, int, 0444); > +MODULE_PARM_DESC(wtsr_en, "Wachdog Timeout & Sofware Reset (default=on)"); > +/* Module parameter for SMPL function control */ > +static int smpl_en = 1; > +module_param(smpl_en, int, 0444); > +MODULE_PARM_DESC(smpl_en, "Sudden Momentary Power Loss (default=on)"); "default=on" is interesting. For what reasons would a user ever want to set this "off"? Can we just remove the options and leave these things enabled all the time for everyone? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
