On Thu, Feb 7, 2013 at 3:18 PM, Michal Simek <[email protected]> wrote: > Fix ioreadXXbe and iowriteXXbe functions which did > additional little endian conversion on native big endian systems. > Using be_to_cpu (cpu_to_be) conversions with __raw_read/write > functions have resolved it. > > Signed-off-by: Michal Simek <[email protected]> > CC: Benjamin Herrenschmidt <[email protected]> > CC: Arnd Bergmann <[email protected]> > CC: Geert Uytterhoeven <[email protected]> > CC: Will Deacon <[email protected]> > CC: [email protected]
I have one question (see below). Apart from that: Acked-by: Geert Uytterhoeven <[email protected]> > -#define ioread16be(addr) be16_to_cpu(ioread16(addr)) > +#define ioread16be(addr) __be16_to_cpu(__raw_readw(addr)) Why did you change it to the __beX_to_cpu variant with underscores? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
