At Mon, 11 Feb 2013 19:49:48 +0400,
Denis Efremov wrote:
>
> snd_ali_pointer function is called with local
> interrupts disabled. However it seems very strange to
> reenable them in such way.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Denis Efremov <[email protected]>
Thanks, applied now.
Takashi
> ---
> sound/pci/ali5451/ali5451.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/pci/ali5451/ali5451.c b/sound/pci/ali5451/ali5451.c
> index 136a393..e760af9 100644
> --- a/sound/pci/ali5451/ali5451.c
> +++ b/sound/pci/ali5451/ali5451.c
> @@ -1435,7 +1435,7 @@ static snd_pcm_uframes_t snd_ali_pointer(struct
> snd_pcm_substream *substream)
>
> spin_lock(&codec->reg_lock);
> if (!pvoice->running) {
> - spin_unlock_irq(&codec->reg_lock);
> + spin_unlock(&codec->reg_lock);
> return 0;
> }
> outb(pvoice->number, ALI_REG(codec, ALI_GC_CIR));
> --
> 1.8.1.2
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
