We don't need to call freezer_do_not_count() for in-kernel users of CLONE_VFORK since exec will get called in bounded time.
We don't want to call freezer_count() for in-kernel users because they may be holding locks. freezer_count() calls try_to_freeze(). We don't want to freeze an in-kernel user because it may be holding locks. In a follow-up patch, I call debug_check_no_locks_held() from try_to_freeze(). After applying this patch, I get no lockdep warnings with that patch. Signed-off-by: Mandeep Singh Baines <[email protected]> CC: Oleg Nesterov <[email protected]> CC: Tejun Heo <[email protected]> CC: Andrew Morton <[email protected]> CC: Rafael J. Wysocki <[email protected]> CC: Ingo Molnar <[email protected]> --- kernel/fork.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/kernel/fork.c b/kernel/fork.c index c535f33..a7cd973 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -722,9 +722,11 @@ static int wait_for_vfork_done(struct task_struct *child, { int killed; - freezer_do_not_count(); + if (current->mm) + freezer_do_not_count(); killed = wait_for_completion_killable(vfork); - freezer_count(); + if (current->mm) + freezer_count(); if (killed) { task_lock(child); -- 1.8.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
