On Mon, Feb 18, 2013 at 01:13:46AM +0100, Andrea Adami wrote: > On Sun, Feb 17, 2013 at 12:00 AM, Anton Vorontsov <an...@enomsg.org> wrote: > > Hi Andrea, > > > > On Sat, Feb 16, 2013 at 07:16:00PM +0100, Andrea Adami wrote: > >> Initial try to fix compilation error > > > > Things are a bit more complex... > > > >> linux/include/linux/mfd/mcp.h:22:16: error: field 'attached_device' has > >> incomplete type > > > > You have to add #include <linux/device.h> into mfd/mcp.h. This will add > > struct device and... > > > Bingo.Adding it solves all following errors, no need for further inclusions. > > >> linux/include/linux/mfd/mcp.h:48:23: error: field 'drv' has incomplete type > > > > struct device_driver. > > > >> linux/include/linux/mfd/ucb1x00.h:137:17: error: field 'dev' has > >> incomplete type > > > > Same here, the file ucb1x00.h needs #include <linux/device.h>. > > > Seems not needed, mcp.h is included by ucb1x00.h
Generally, we don't depend on indirect inclusions. But if it doesn't harm anyhow so far, we may not bother with this. Thanks, Anton -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
