On Fri, Feb 15, 2013 at 12:56:33PM +0000, Lee Jones wrote: > + if (gpadc->regu) > + regulator_disable(gpadc->regu);
No explanation for this in the changelog and missing error handling like this is pretty much always terrible style. Why are we doing this? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/