On Mon, Feb 25, 2013 at 05:23:17PM -0800, 'Tejun Heo' wrote: > again, why do we need the WARN_ON() at all given that other > devm_*_match() don't do that and the only way to get NULL there would > be bug in devm_rtc*() code itself rather than its users?
Ughh... I see that you probably copied the chunk from clk / regulator implementation. Let's please not copy those. Input validation via WARN_ON()s is nice when the interface is taking input from outside or the code in question is complex / fragile. Here, the code involved is like 20 lines and self-contained. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
