On Mon, Mar 04, 2013 at 09:32:03PM -0700, Jason Gunthorpe wrote: > On Tue, Mar 05, 2013 at 11:53:02AM +0800, Feng Tang wrote:
> > > You may want to also CC the maintainers of all the ARM subsystems that > > > use read_persistent_clock and check with them to ensure this new > > > interface will let them migrate their implementations as well. > > > > Maybe I didn't get it well, my patches didn't change the > > read_persistent_clock(), but inject a new way of counting suspended > > time. It should have no functional changes to existing platforms. > > Right, your patches are fine stand alone. > > The ARM case of plat-omap/counter_32k.c would ideally be converted to > use your new API though, that is what I ment about involving them. I see now. Yes, the counter_32k could be converted to a clocksource with SUSPEND_NONSTOP flag set, and no need for it to use the read_persistent_clock any more. > > I'm not sure about mach-tegra/timer.c though - it seems to be using a > counter as well but somehow sharing registers with the RTC? I just searched the 3.9-rc1 code, seems the file has been moved to drivers/clocksource/tegra20_timer.c, and its persistent clock seems to also be based on a RTC like device. Thanks, Feng -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
